Add download alias for hf_hub_download to HfApi
#1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
changed the title
hf_hub_download to HfApi
|
The documentation is not available anymore as the PR was closed or merged. |
|
Thanks for the reviews! I'm merging it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #1573 and #1082.
endpointto bothhf_hub_downloadandsnapshot_download. Let's be honest, this is used only in unit tests to change to staging endpoint. At least it is aligned with other methods from huggingface_hub (was not the case before)hf_hub_downloadandsnapshot_downloadas aliases inHfApiclass. Idea has been discussed on slack (internal link). The main goal is to reuse endpoint, user-agent, token,... parameters from the HfApi instance instead of passing them into each individual call (same asupload_fileandupload_foldercurrently).cc @severo @mariosasko for #1082
cc @Narsil @hysts for #1573
(note: failing tests are unrelated)